- Feb 22, 2025
-
-
Mark Harris authored
-
Mark Harris authored
-
Petter Reinholdtsen authored
-
Petter Reinholdtsen authored
Changed identifiers in code to avoid standard C/C++ naming convention conflict. Closes #11 See merge request !19
-
- Feb 20, 2025
-
-
Petter Reinholdtsen authored
-
Petter Reinholdtsen authored
-
Petter Reinholdtsen authored
Dropped unused conflicting identifiers where possible and renamed code identifiers from _something to something_ when the identifiers were used. Only internal identifiers were changed, so no API/ABI change. These were tracked down using clang -Wreserved-identifier. Extended clang CI check to detect such issues in the future. Fixes #11.
-
Petter Reinholdtsen authored
This could detect issues not discovered by valgrind.
-
Petter Reinholdtsen authored
New Debian and rewritten autoconf/automake logic fixed the issue.
-
Collin Funk authored
Since all abbreviated months are three characters followed by a NUL byte, this buffer should be 4 bytes.
-
Petter Reinholdtsen authored
Leftover from 25431ddc.
-
Petter Reinholdtsen authored
Three implementations in tools/ were dropped and one common implementation from oggz_byteorder.h is used instead.
-
- Feb 19, 2025
-
-
Petter Reinholdtsen authored
<URL: https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier > states: "Each name that contains a double underscore __ or begins with an underscore followed by an uppercase letter is reserved to the implementation for any use." Changed all header files to avoid conflicting with this convention. Related to #11, but there are other conflicting identifiers left.
-
- Feb 18, 2025
-
-
Petter Reinholdtsen authored
-
Petter Reinholdtsen authored
Ran autoupdate and edited setup until most warnings disappeared.
-
Petter Reinholdtsen authored
Switched valgrind run to use LOG_COMPILER and fail on valgrind errors. See merge request !17
-
Petter Reinholdtsen authored
This wil avoid running valgrind on bash and instead validate the test programs themselves.
-
- Feb 08, 2025
-
-
Petter Reinholdtsen authored
-
Petter Reinholdtsen authored
-
Petter Reinholdtsen authored
Disabled shared library building, as the linker could not find -lc. Fetches latest Ogg library from git and build it for Windows to have it available for Oggz.
-
Petter Reinholdtsen authored
-
- Feb 07, 2025
-
-
Petter Reinholdtsen authored
-
Ralph Giles authored
fixed random access offsets See merge request !10
-
Petter Reinholdtsen authored
-
Jan Sablatnig authored
-
Ralph Giles authored
Introduced new configure option --enable-debug to build with -DDEBUG. See merge request xiph/liboggz!12
-
Ralph Giles authored
Bring OggzStreamContent enum in line with documented return values. Closes #16 See merge request !13
-
Ralph Giles authored
Stop trying to read comments outside the ogg package available. Closes #14 See merge request xiph/liboggz!11
-
Ralph Giles authored
Avoid reading invalid memory in dirac_frate_tbl. Closes #15 See merge request xiph/liboggz!7
-
Ralph Giles authored
Avoid crash when inserting comment with no value. Closes #13 See merge request xiph/liboggz!14
-
- Feb 05, 2025
-
-
Petter Reinholdtsen authored
This fixes the following issue as reported by valgrind: ==2828942== Invalid read of size 1 ==2828942== at 0x4847743: __strcmp_sse42 (vg_replace_strmem.c:927) ==2828942== by 0x485505A: oggz_comment_cmp (oggz_comments.c:219) ==2828942== by 0x485505A: oggz_comment_cmp (oggz_comments.c:213) ==2828942== by 0x485B243: oggz_vector_tail_insertion_sort (oggz_vector.c:237) ==2828942== by 0x485B243: oggz_vector_insert_p (oggz_vector.c:286) ==2828942== by 0x4855B5F: oggz_comments_decode (oggz_comments.c:664) ==2828942== by 0x485A86D: oggz_auto_read_comments (oggz_auto.c:1510) ==2828942== by 0x4856E43: oggz_read_sync (oggz_read.c:456) ==2828942== by 0x485738B: oggz_read (oggz_read.c:650) ==2828942== by 0x10AD64: validate (oggz-validate.c:445) ==2828942== by 0x10A431: main (oggz-validate.c:594) ==2828942== Address 0x0 is not stack'd, malloc'd or (recently) free'd ==2828942== ==2828942== ==2828942== Process terminating with default action of signal 11 (SIGSEGV) ==2828942== Access not within mapped region at address 0x0 ==2828942== at 0x4847743: __strcmp_sse42 (vg_replace_strmem.c:927) ==2828942== by 0x485505A: oggz_comment_cmp (oggz_comments.c:219) ==2828942== by 0x485505A: oggz_comment_cmp (oggz_comments.c:213) ==2828942== by 0x485B243: oggz_vector_tail_insertion_sort (oggz_vector.c:237) ==2828942== by 0x485B243: oggz_vector_insert_p (oggz_vector.c:286) ==2828942== by 0x4855B5F: oggz_comments_decode (oggz_comments.c:664) ==2828942== by 0x485A86D: oggz_auto_read_comments (oggz_auto.c:1510) ==2828942== by 0x4856E43: oggz_read_sync (oggz_read.c:456) ==2828942== by 0x485738B: oggz_read (oggz_read.c:650) ==2828942== by 0x10AD64: validate (oggz-validate.c:445) ==2828942== by 0x10A431: main (oggz-validate.c:594) The problem is triggered when oggz_comments_decode() is calling _oggz_comment_add_byname() with NULL as its third argument. Not sure what should happen with a comment consisting only of a name and no value, but the provided patch block the crash from occuring. Fixes #13
-
Petter Reinholdtsen authored
-
Petter Reinholdtsen authored
-
Petter Reinholdtsen authored
-
Petter Reinholdtsen authored
-
Petter Reinholdtsen authored
According to the documentation of oggz_stream_get_content(), it can return values OGGZ_ERR_BAD_OGGZ and OGGZ_ERR_BAD_SERIALNO, neither which is part of the return type enum OggzStreamContent. This causes the following compiler warning and make it impossible to check the return value of this method without a compiler warning: oggz_stream.c: In function ‘oggz_stream_get_content’: oggz_stream.c:55:28: warning: implicit conversion from ‘enum OggzError’ to ‘OggzStreamContent’ [-Wenum-conversion] 55 | if (oggz == NULL) return OGGZ_ERR_BAD_OGGZ; | ^~~~~~~~~~~~~~~~~ oggz_stream.c:58:30: warning: implicit conversion from ‘enum OggzError’ to ‘OggzStreamContent’ [-Wenum-conversion] 58 | if (stream == NULL) return OGGZ_ERR_BAD_SERIALNO; | ^~~~~~~~~~~~~~~~~~~~~ This fix provide new enum members OGGZ_CONTENT_ERR_BAD_OGGZ and OGGZ_CONTENT_ERR_BAD_SERIALNO with identical integer values as the OGGZ_ERR_* values, ensuring ABI compatilibity while providing types accepted by the compiler. Fixes #16
-
Petter Reinholdtsen authored
-
Petter Reinholdtsen authored
Use PRId64 or %zu where appropriate. Handle NULL values.
-
Petter Reinholdtsen authored
This activate several blocks of code that should compile. Some of them did not after the introduction of UNUSED(). Flag the arguments used with -DDEBUG with a new macro NDUNUSED(). There are several new compiler warnings in the DEBUG protected code. When these are fixed, --enable-gcc-werror could be enabled for DEBUG builds to avoid reintroducing such problems.
-
Petter Reinholdtsen authored
This avoid a compiler warning about incorrect formatting string.
-