This will be run on the CI (and on distcheck hopefully), so should
prevent someone accidentally bumping the version only in one build.

- In addition to --with-speex=PREFIX, allow --with-speex=yes (to use the speex
  library from --speex-libraries=DIR and includes from --speex-includes=DIR, or
  from the default system directories) or --with-speex=no (to disable use of
  speex), to match opus.m4
- Fix -Wstrict-prototypes
- Fix misspelling

The Windows specific header wave_out.h is redefining various
gnu compiler specific keywords. It was likely introduced when things
got ported to MSVC, but it didn't take mingw into account.

There are two problems, __attribute__() gets used in system headers and
removing it can change behaviour and "restrict" being removed can
lead to less optimized code. __inline seems to work fine though, but is not needed.

CFLAGS="-D_FORTIFY_SOURCE=2 -O2" exposed this now because a required
__attribute__() is missing:

In file included from speexdec.c:54:
C:/msys64/ucrt64/include/io.h: In function '_open':
C:/msys64/ucrt64/include/io.h:407:7: error: invalid use of '__builtin_va_arg_pack_len ()'
  407 |   if (__builtin_va_arg_pack_len() > 1)

Fix by only enabling those macros when building with MSVC.

Kai Pastor authored 2 years ago and Tristan Matthews committed 2 years ago

Signed-off-by: Tristan Matthews <tmatth@videolan.org>

orbea authored 3 years ago and Tristan Matthews committed 3 years ago

(cherry picked from speexdsp@68311d46

)
Signed-off-by: Tristan Matthews <tmatth@videolan.org>

Luca Barbato authored 3 years ago and Tristan Matthews committed 3 years ago

Signed-off-by: Tristan Matthews <tmatth@videolan.org>

(cherry-picked from: xiph/speexdsp@ce516455)

Refs #2038

With apologies to anyone still using cvs for speex development.

Tristan Matthews authored 4 years ago and Ralph Giles committed 4 years ago

Fixes #13

Invoke `make check` at the end of the default build, since we
don't do `make distcheck` for all the jobs. At the moment this
does nothing, but it should give better coverage if any test
harnesses are hooked up to the target.

We only really need distcheck to succeed for the default autotools
build, so save time by only running that step once.

Signed-off-by: Tristan Matthews <tmatth@videolan.org>
Signed-off-by: Marvin Scholz <epirat07@gmail.com>

Do additional builds to test the various configure switches.
This gives us better parity with the travis ci builds.

Signed-off-by: Tristan Matthews <tmatth@videolan.org>
Signed-off-by: Marvin Scholz <epirat07@gmail.com>

Do a basic autoconf build and check to verify commits
in gitlab reposistories.

Signed-off-by: Tristan Matthews <tmatth@videolan.org>
Signed-off-by: Marvin Scholz <epirat07@gmail.com>

Fixes ubsan error in fuzzer:
"runtime error: signed integer overflow: 9223372036854775807 - -1 cannot be represented in type 'long'"

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/speex

Fixes ubsan error in fuzzer:
   "runtime error: signed integer overflow: 2147483616 + 160 cannot be represented in type 'int'

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/speex

Fixes ubsan error:
"runtime error: signed integer overflow: 51200 - -9223372036854767360 cannot be represented in type 'long'"

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/speex

Tyson Smith authored 5 years ago and Tristan Matthews committed 5 years ago

Signed-off-by: Tristan Matthews <tmatth@videolan.org>

Fixes ubsan error:
"runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself"

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/speex

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/speex

Co-Authored by Tyson Smith <twsmith@mozilla.com>

This avoids an integer overflow.

Backported from opus commit 1ee139bca076a1a3606a8a924a698d356d40cbb8

This should yield output comparable to the wavs at https://www.speex.org/samples/

Fixes hang discovered by fuzzing: https://github.com/xiph/speex/issues/9

Michael Fink authored 7 years ago and Tristan Matthews committed 7 years ago

Fixes #2037

Signed-off-by: Tristan Matthews <tmatth@videolan.org>

Martin Storsjö authored 7 years ago and Tristan Matthews committed 7 years ago

_WIN32 is always defined by the compiler automatically when targeting
that platform, while WIN32 only is defined automatically in some
configurations, and e.g. in MSVC only ever is defined in project files
(if at all).

Some other checks in the codebase already check for both WIN32 and
_WIN32; those are left untouched.

Martin Storsjö authored 7 years ago and Tristan Matthews committed 7 years ago

This fixes warnings in calling code about "this function declaration
is not a prototype".