If the METADATA_BLOCK_PICTURE field contained a non-empty mimetype
 or description field, then we would overwrite important pieces of
 the struct when encoding, making the tag useless.

Signed-off-by: Ralph Giles <giles@mozilla.com>

This provides a fallback commit id if no tags are available,
for example when doing a shallow clone.

Previously we linked to flac, but didn't set the enabling CFLAG.

wave_out.c also references PACKAGE_NAME and PACKAGE_VERSION.

GNU autotools used to enforce some coding standards, but I don't
see a warning about not having this or a changelog now.

This should have no real functional change at this point in time,
but it's clear that Ogg will never depend on Opus.  The reverse is
likely to remain true, but less axiomatic.

Only opusenc uses it at present.

Garf's new project files build things in win32/VSnnnn/ instead
of the top level. Also updates the ogg paths to use defines
instead of hard-coding release and platform tags.

It was still defining VERSION in the Visual Studio project files,
which hadn't been updated for this change.

Include the doc fixes from 3138cb7c,
even if people don't want the --quality alias after all.

This avoids at least one case where ./autogen.sh && ./configure && make
will re-run configure because the makefile rules updated something that
it depends upon. Pulling a new version from git will change the version
so we should update that at the first step rather than iterating after
the last one.

This reverts commit 3138cb7c.

This updates the configure.ac requirements for the last patch from
 JM, and also fixes the unused variable warnings it created.

Jean-Marc Valin authored 11 years ago and Gregory Maxwell committed 11 years ago

Channel mapping is now determined automatically by libopus.
This breaks the --uncoupled option because opusenc no longer
has any control over the mapping.

Automake 1.13 complains that INCLUDES is obsoleted now.

Test for the available possibilities in the code in the same order that
we use when including the headers.  This ensures that BSDs which test
positive for both sndio and oss compat won't include the headers for one
and the code for the other.  The sndio support was added in commit
064bb217, but only preferred sndio when
including the headers.

Enable the OSS code for all the possible HAVE_*_SOUNDCARD_H options.
A more comprehensive test and additional macros were added in commit
a0c50052, but only to include the
headers, not to also enable the relevant code.

Nothing uses it either.

It is declared to be obsolete and we already use AC_COMPILE_IFELSE
everywhere else, so finish the job to avoid confusion and people
pasting more instances of it in later.

Double quote all the parameters to AC_LANG_SOURCE and AC_LANG_PROGRAM.
This is actually required, even if you can get away with not doing it
sometimes, so again set a good example for future changes to follow,
to hopefully avoid people getting bitten harder than they need to be.

And the exp() check too.  Nothing in the code actually tests for that
and it's irrelevant whether it needs libm or not, since plenty of other
things definitely do need it.

So add the hardcoded -lm back where it is definitely needed (at the
very least for the speex resampler), and make sure it is in LIBS when
we test for lrint and f{min,max}f, since those tests do fail on Linux
if libm isn't linked.

It's not just for the weak.

Fix the libm exp() test to not unconditionally add it to everything via
LIBS, and fix opus{enc,dec}_LDADD to actually use LIBM that it sets
rather than hardcoding it there as well.

Use AS_HELP_STRING to format all option descriptions.

Get rid of a bunch of shadow variables that aren't really needed.

Drop the x warts in tests, it really isn't needed, and there are lots
of places we don't use it, so if it was they'd already be exploding.

Let the pkg-config tests actually fail if they don't find the desired
package, rather than also running the manual test which will just fail
again in that case.

Don't overlink flac with -lm in the manual test.  That was fixed in
its .pc in commit 5da86630bee2336e251f0a140f33332af703c43e.

Change --disable-flac to --without-flac.  The normal autoconf idiom is
to use 'enable' for intrinsic features and 'with' for external software
support that is optional.

Change Opus_{CFLAGS,LIBS} to OPUS_{CFLAGS,LIBS}, since that what opus.m4
will try to set if pkg-config isn't available.

Drop the check for __malloc_hook, we don't use it anywhere here.

These were probably cribbed from libopus, where they aren't used either,
which was probably cribbed from libogg where they are.  We definitely
don't need them here since we get all our sized types from elsewhere.

This one meets or exceeds the following requirements:

 - Version is checked/updated for every build action when in the git repo.
   Does not require the user to re- ./configure to get the correct version.

 - Version is not updated automatically when using exported tarball source.
   Avoids accidentally getting a wrong version from some other git repo in
   a parent directory of the source, and allows setting the correct version
   for distro package exports.

 - Automatic updating can be manually suppressed.
   For developers doing lots of change/rebuild cycles they don't plan to
   release, when they don't want a full rebuild triggered for every commit,
   and again for every change made immediately after a commit.
   The version will still always be updated if they do a `make dist`.

 - Does not require any manual updating of versions in the mainline git
   repo for each release aside from normal tagging.  The version is
   recorded in one file only, that is automatically generated and will
   never need to be committed.

 - Does not require gnu-make features for the autoconf builds.

It does not currently:

 - Keep a checksum of every source file in tarball releases to mangle the
   version if people modify the tarball source.  Responsible people can
   manually update the version easily though in such cases.

So that we can see what they are actually for, and only apply them to
the files that actually need them.

If this was really needed the other tools would need it too (and would be
failing to build wherever it was).  If the normal mechanism for setting
them isn't working somewhere we should fix that instead.

If this was really needed the other tools would be failing to compile.
And if they are, we should fix that at the cause for all of them.